maciejpi/nordabiz
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(messages): restore polling for own messages + content-based dedup for optimistic
Some checks are pending
NordaBiz Tests / Unit & Integration Tests (push) Waiting to run
Details
NordaBiz Tests / E2E Tests (Playwright) (push) Blocked by required conditions
Details
NordaBiz Tests / Smoke Tests (Production) (push) Blocked by required conditions
Details
NordaBiz Tests / Send Failure Notification (push) Blocked by required conditions
Details

Browse Source
This commit is contained in:
Maciej Pienczyn 2026-03-28 17:43:31 +01:00
parent 8ac13f47b2
commit 406752fca2
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
static/js/conversations.js
View File

@ -727,8 +727,22 @@
if (!state.messages[convId]) state.messages[convId] = []; if (!state.messages[convId]) state.messages[convId] = [];
// Dedup: skip if message with this ID already exists // Dedup: skip if message with this ID already exists
// Simple dedup by ID (string or number) // Dedup: by real ID or by matching optimistic message (same sender + content)
if (msg.id && state.messages[convId].some(function(m) { return m.id === msg.id; })) return; var dominated = state.messages[convId].some(function(m) {
if (m.id === msg.id) return true;
// Match optimistic msg: same sender, same stripped content
if (m._optimistic && msg.sender_id && m.sender_id === msg.sender_id) {
var mc = (m.content || '').replace(/<[^>]*>/g, '').trim();
var nc = (msg.content || '').replace(/<[^>]*>/g, '').trim();
if (mc && nc && mc === nc) {
m.id = msg.id; // Update to real ID
m._optimistic = false;
return true;
}
}
return false;
});
if (dominated) return;
state.messages[convId].push(msg); state.messages[convId].push(msg);
if (convId !== state.currentConversationId) return; if (convId !== state.currentConversationId) return;
@ -1714,12 +1728,8 @@
if (!data.messages || !data.messages.length) return; if (!data.messages || !data.messages.length) return;
// Find messages newer than what we have // Find messages newer than what we have
var currentUserId = window.__CURRENT_USER__ ? window.__CURRENT_USER__.id : null;
var newMsgs = data.messages.filter(function (msg) { var newMsgs = data.messages.filter(function (msg) {
if (msg.id <= newestId) return false; return msg.id > newestId;
// Skip own messages — already displayed by optimistic UI
if (currentUserId && msg.sender_id === currentUserId) return false;
return true;
}); });
if (newMsgs.length > 0) { if (newMsgs.length > 0) {